On Wed, Sep 29, 2010 at 06:09:21PM -0600, Eric Blake wrote:
* src/qemu/qemu_driver.c (qemudDomainSetVcpusFlags) (qemudDomainGetVcpusFlags): Support all feasible flag combinations. ---
Aargh - my ISP SMTP server said that 11 emails is the limit for one session, so I have to resend the last two of my series (and figure out how to config git to use multiple sessions to avoid that problem in the future).
worked fine, I saw them in a batch, properly aligned,
Anyways, this is the meat of the patch series, in converting qemu 0.12+ to remember whether vcpus have been hot-unplugged below the maximum, in order to boot that way the next time around. I'm a bit fuzzy on whether I used all the driver internals correctly, especially on how and when vm->newDef should be created for managing persistent state separately from live state, so a careful review is appreciated, and I'll probably need a v2. [...] - ret = qemudDomainHotplugVcpus(vm, nvcpus); + switch (flags) { + case VIR_DOMAIN_VCPU_MAXIMUM | VIR_DOMAIN_VCPU_PERSISTENT:
hum I usually indent the cases 4 spaces from the switch, minor nit ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/