On Sat, Jun 30, 2018 at 02:30:15PM +0530, Sukrit Bhatnagar wrote:
By making use of GNU C's cleanup attribute handled by the VIR_AUTOPTR macro for declaring aggregate pointer variables, majority of the calls to *Free functions can be dropped, which in turn leads to getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com> --- src/util/vircommand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c index d328431..6edb4d5 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -823,10 +823,9 @@ int virRun(const char *const*argv, int *status) { int ret; - virCommandPtr cmd = virCommandNewArgs(argv); + VIR_AUTOPTR(virCommand) cmd = virCommandNewArgs(argv);
ret = virCommandRun(cmd, status); - virCommandFree(cmd);
You can return virCommandRun directly.
return ret;
With that: Reviewed-by: Erik Skultety <eskultet@redhat.com>