On 22.03.2013 18:32, Stefan Berger wrote:
On 03/22/2013 07:44 AM, Michal Privoznik wrote:
Adapt code under src/util/ to fact, that VIR_ALLOC* now reports OOM error. There is no need to report it twice now. ---
Maybe an sed script could help here at least in removing the virReportOOMError, not so easily in removing the '{' and '}'. Now I doubt we will see lots of OOM errors, but there are a lot more that may now report twice ...
ACK
Yep. This is just a patch to show off how much we are going to save. But now that I am thinking this over again - maybe virAsprintf deserves to report OOM error as well (for virlog.c and virerror.c we are gonna need virAsprintf variant without OOM error reporting). And probably a wrapper over strdup as well - again with OOM error reporting. I just don't know if I should do all the adaptation in one patch patch set or in three different series. BTW: I am not that strong in RE, so I am doing this with vim macros. Michal