Re: [libvirt] [PATCH V2] nwfilter: lock interface by its index
Daniel Veillard <veillard(a)redhat.com> wrote on 04/22/2010 07:41:47 AM:
[...]
>
> + if (virNWFilterLockIface(req->ifname))
> + goto err_no_lock;
> +
As long as the error is caught when used, and properly propagated
that strategy is correct IMHO.
otherwise, patch looks okay to me,
ACK once those forever loops are replaced with error returns.
I fixed this and pushed it. I had to also remove an ifaceDown() call and
precede another one with ifaceCheck().
Stefan
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
Attachments:
- attachment.html (text/html — 1.5 KB)