Re: [libvirt] [PATCH v2 01/12] qemu: qemuDomainJobInfoToParams drop unused code

On Wed, Dec 28, 2016 at 17:39:10 +0300, Nikolay Shirokovskiy wrote: > qemu driver does not have VIR_DOMAIN_JOB_BOUNDED jobs. > --- > src/qemu/qemu_domain.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index acfa695..acc27d0 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -432,12 +432,6 @@ qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo, > jobInfo->timeElapsed - jobInfo->timeDelta) < 0) > goto error; > > - if (jobInfo->type == VIR_DOMAIN_JOB_BOUNDED && > - virTypedParamsAddULLong(&par, &npar, &maxpar, > - VIR_DOMAIN_JOB_TIME_REMAINING, > - jobInfo->timeRemaining) < 0) > - goto error; > - > if (stats->downtime_set && > virTypedParamsAddULLong(&par, &npar, &maxpar, > VIR_DOMAIN_JOB_DOWNTIME, The function is supposed to process all fields in qemuDomainJobInfo and we should keep it so. If we want to drop this code, we should just drop qemuDomainJobInfo.timeRemaining completely.