Re: [Libvir] [PATCH] * qemud/remote.c: Don't include <getopt.h>. Not used.

On Wed, Mar 19, 2008 at 01:11:18PM +0000, Richard W.M. Jones wrote: > On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: > > I had a few in-progress changes from a week or two ago, > > and am clearing the decks. > > > > I added a new build-checking rule (coming separately) > > and it exposed an unnecessary include: > > +1 > > So we have a way to find header files which are unused? No - this is impossible unless you have a copy of every OS we've ever tested on. It may be unused on Linux, but may be needed on Solaris, etc etc. Removing <getopt.h> is an obviously safe action, but in general we should be wary of removing supposedly unused heads.