Re: [libvirt] [PATCH] qemu: maintain user alias for video type 'none'
On Fri, Sep 06, 2019 at 09:58:32AM +0200, Erik Skultety wrote:
On Thu, Sep 05, 2019 at 11:17:38AM -0500, Jonathon Jongsma wrote:
> After parsing a video device with a model type of
> VIR_DOMAIN_VIDEO_TYPE_NONE, all device info is cleared (see
> virDomainDefPostParseVideo()) in order to avoid formatting any
> auto-generated values for the XML. Subsequently, however, an alias is
> generated for the video device (e.g. 'video0'), which results in an
> alias property being formatted in the XML output anyway. This creates
> confusion if the user has explicitly provided an alias for the video
> device since the alias will change.
>
> To avoid this, don't clear the user-defined alias for video devices of
> type "none".
>
> See https://bugzilla.redhat.com/show_bug.cgi?id=1720612
s/See// - we had a discussion about using/not using "Resolves: <url>"
across
the commit messages; right now, the custom is to mention just the plain URL.
'Resolves:' is just redundant noise - people only do it out of habit because
Red Hat's own internal dev tools for RHEL require that for beurocratic
reasons.
In any case, the most important rule is that the commit message should fully
describe the problem. ie it should be possible to understand the commit
without opening the BZ link at all.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|