Re: [libvirt] [PATCH v3 34/34] Introduce syntax-check rule to prefer VIR_STRDUP over strdup
On 05/09/2013 04:39 AM, Michal Privoznik wrote:
>>
>> +exclude_file_name_regexp--sc_prohibit_strdup = \
>> + ^(docs/|examples/|python/|src/util/virstring\.c$$|tools/virsh\.c$$)
>
> Do we really need to allow strdup() in the python c code? Likewise for
> tools/virsh.c?
Do you mean we should s/strdup/VIR_STRDUP/ within vshStrdup?
Might as well - it never hurts to be consistent in as many places as
possible.
And I'll fix python surely.
Michal
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)