Re: [libvirt] [PATCH 1/5] conf: add support for specifying CPU "dies" parameter

Recently CPU hardware vendors have started to support a new level of inside the CPU package topology known as a "die". Thus the hierarchy is now: sockets > dies > cores > threads This adds support for "dies" in the XML parser, with the value defaulting to 1 if not specified for backwards compatibility. For example a system with 64 logical CPUs might report <topology sockets="4" dies="2" cores="4" threads="2"/> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; --- docs/formatcaps.html.in | 2 +-

@@ -1059,6 +1067,12 @@ virCPUDefIsEqual(virCPUDefPtr src, goto cleanup; } + if (src->dies != dst->dies) { + MISMATCH(_("Target CPU dies %d does not match source %d"), + dst->dies, src->dies); + goto cleanup; + } + if (src->cores != dst->cores) { MISMATCH(_("Target CPU cores %d does not match source %d"), dst->cores, src->cores);