Re: [libvirt] [PATCH RFC 02/39] qemu: monitor: Allow using 'id' instead of 'device' for 'block_set_io_throttle'

On Wed, Jul 25, 2018 at 05:57:33PM +0200, Peter Krempa wrote:

The 'device' argument matches only the legacy drive alias. For blockdev we need to set the throttling for a QOM id and thus we'll need to use the 'id' field.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor.c | 8 +++++--- src/qemu/qemu_monitor.h | 3 ++- src/qemu/qemu_monitor_json.c | 14 ++++++++++---- src/qemu/qemu_monitor_json.h | 3 ++- tests/qemumonitorjsontest.c | 2 +- 6 files changed, 21 insertions(+), 11 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano