Re: [libvirt] [PATCH] bridge: Fix uninitialized variable

3 Jan 2011


      ...
...
@@ -715,7 +715,7 @@ brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED,
                   virSocketAddr *addr,
                   unsigned int prefix)
  {
-    virCommandPtr cmd;
+    virCommandPtr cmd = NULL;
      char *addrstr;
      int ret = -1;
Wow! How did I miss *that*?!?
Thanks for catching it!
(Beyond that - what options are you using that it didn't build?
I always build with --enable-compile-warnings=error so any compiler warning
results in build failure. No special options beyond that.

Jirka

    

Jiri Denemark