On 10/07/13 16:59, Eric Blake wrote:
On 10/07/2013 08:16 AM, Peter Krempa wrote:
...
Again - I dislike having these sentinel values showing up in switch statements (searching the source I see it a lot), as it could lead someone to believe that those are actually valid values. I may be outvoted on this though :-)
I think that the benefits of the compiler warning in case you add a new variable on places you might have forgotten outweigh a few occurences of unused type in the code.
Agreed. Maybe we should patch HACKING to capture the outcome of this discussion.
I pushed this one with two trivial fixes according to ACK from Laine. Fixes done were: Removed double space in one of the conditions and changed the second addition of backend variable to non-pointer. Peter