Re: [libvirt] [PATCH] virsh: avoid bogus description
On 06/20/2011 08:22 PM, Wen Congyang wrote:
> +++ b/tools/virsh.c
> @@ -12113,7 +12113,8 @@ vshCmddefHelp(vshControl *ctl, const char *cmdname)
> vshError(ctl, _("command '%s' doesn't exist"),
cmdname);
> return false;
> } else {
> - const char *desc = _(vshCmddefGetInfo(def, "desc"));
> + /* Don't translate desc until after we know it isn't "".
*/
Can two prepositions use together?
As a native speaker, I didn't notice anything wrong with that use
(actually, I might have inserted "that" between "know it"), but I used
a
shorter phrase altogether that should be easier to parse:
/* Don't translate desc if it is "". */
ACK except the comment.
Now pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)