Re: [libvirt] [PATCH 2/2] device_conf: PCI address pci_0000_00_00_0 is also valid

On 08/05/2014 10:18 AM, Pavel Hrdina wrote: I think we're going to need more than this :( domain_conf.c uses it to feed this code in virDomainNetFindIdx: bool PCIAddrSpecified = virDomainDeviceAddressIsValid(&net->info, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); Right now, if you omit an <address> element, it is 0-initialized and the in-memory structure happens to be pci_0000_00_00_0, but PCIAddrSpecified is set to false, which then lets us auto-pick an appropriate (non-zero) address. If you explicitly specify an all-0 address, you get the same behavior. With your patch, it looks like you want to allow explicit specification of an all-0 address. But for that to work, we now need to modify domain_conf.h (and/or device_conf.h) to ALSO have a bool flag that says whether an address was specified (since you are allowing explicit specification of all-0, where we should NOT auto-assign a different address) or omitted. NACK to this version; the correct solution is one where an explicit all-0 address behaves differently than omitting <address>. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org