Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: ... >> + * Run each virtualization driver's "active" method. >> + * >> + * Return 0 if successful, -1 upon error. >> + */ >> int virStateActive(void) { >> int i, ret = 0; >> >> for (i = 0 ; i < virStateDriverTabCount ; i++) { >> if (virStateDriverTab[i]->active && >> virStateDriverTab[i]->active()) >> - ret = 1; >> + ret = -1; > > This is *not* an error condition. This method is basically asking > whether the driver is 'active' - eg, does it have any domains > running. It returns 0 if it isn't active, or 1 if it is active. > > There is no error scenario - it can never fail. Ah. I see what you mean. This is better: From a85968eed75cdbcf8848ea62b2739469fd6a9d60 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com&gt; Date: Mon, 24 Nov 2008 15:52:55 +0100 Subject: [PATCH 1/3] libvirt.c: document the virState* functions