Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser
Now, earlier in this loop (not visible in this limited context
though)
there's a check for VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK type. I
don't think it is special so we have two options:
a) move it into virDomainGraphicsListenDefValidate(), or
b) move those checks out of virDomainGraphicsListenDefValidate() right
into this loop; rendering virDomainGraphicsListenDefValidate() to be an
empty function which can then be dropped.
I don't have any preference, do you?
Michal
Greetings Sir
Let's go with option b), as it reduces the number of functions, moreover
the function virDomainGraphicsListenDefValidate() has a pretty similar
name to it's caller virDomainGraphicsDefListensValidate() and could be
kindof annoying.
Do I apply your suggestion and resend the patch?
Thank You
Shiva