Re: [libvirt] [PATCH] Do more complete initialization of libgcrypt
On 04/13/2013 04:54 AM, SHREE DUTH AWASTHI wrote:
Hi Daniel,
Thanks a lot for the patch, yes it is working as expected.
[Please don't top-post on technical lists]
# virsh -c qemu://localhost/system version
Compiled against library: libvirt 0.10.2
Using library: libvirt 0.10.2
Using API: QEMU 0.10.2
Running hypervisor: QEMU 0.14.1
But can you please clarify my below query.
Do we really need the red coloured lines as well ?
This list rejects html mail. Thus, we don't see any red-colored lines
in your message.
Our patch :
In function virInitialize()
+ #ifdef WITH_GNUTLS
- gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl);
- gcry_check_version(NULL);
+ if (gcry_control(GCRYCTL_ANY_INITIALIZATION_P) == 0) {
+ gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl);
+ gcry_check_version(NULL);
+
+ gcry_control(GCRYCTL_DISABLE_SECMEM, NULL, 0);
+ gcry_control(GCRYCTL_INITIALIZATION_FINISHED, NULL, 0);
+ gcry_control(GCRYCTL_ENABLE_QUICK_RANDOM, 0);
+ }
+ #endif
The only difference between this and what Dan posted appears to be the
#ifdef WITH_GNUTLS; was your patch prepared against libvirt.git?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)