Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
.../generic-chardev-tcp-missing-host.xml | 25 ++++++++++++++++
.../generic-chardev-tcp-missing-service.xml | 25 ++++++++++++++++
tests/genericxml2xmlindata/generic-chardev-tcp.xml | 32 ++++++++++++++++++++
.../genericxml2xmloutdata/generic-chardev-tcp.xml | 35 ++++++++++++++++++++++
tests/genericxml2xmltest.c | 6 ++++
5 files changed, 123 insertions(+)
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp.xml
create mode 100644 tests/genericxml2xmloutdata/generic-chardev-tcp.xml
diff --git a/tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
b/tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
new file mode 100644
index 0000000000..523c34f29b
--- /dev/null
+++ b/tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml
@@ -0,0 +1,25 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-i686</emulator>
+ <controller type='virtio-serial' index='0'/>
+ <channel type='tcp'>
+ <source mode='bind' service='5678'/>
+ <protocol type='raw'/>
+ <target type='virtio' name='test2'/>
+ </channel>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
b/tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
new file mode 100644
index 0000000000..880f07436a
--- /dev/null
+++ b/tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml
@@ -0,0 +1,25 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-i686</emulator>
+ <controller type='virtio-serial' index='0'/>
+ <channel type='tcp'>
+ <source mode='bind' host='localhost'/>
+ <protocol type='raw'/>
+ <target type='virtio' name='test1'/>
+ </channel>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/genericxml2xmlindata/generic-chardev-tcp.xml
b/tests/genericxml2xmlindata/generic-chardev-tcp.xml
new file mode 100644
index 0000000000..e59c572a12
--- /dev/null
+++ b/tests/genericxml2xmlindata/generic-chardev-tcp.xml
@@ -0,0 +1,32 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-i686</emulator>
+ <controller type='virtio-serial' index='0'/>
+ <channel type='tcp'>
+ <source host='localhost' service='5678'/>
+ <target type='virtio' name='test1'/>
+ </channel>
+ <channel type='tcp'>
+ <source mode='connect' host='localhost'
service='5678'/>
+ <target type='virtio' name='test2'/>
+ </channel>
+ <channel type='tcp'>
+ <source mode='bind' host='localhost'
service='5678'/>
+ <target type='virtio' name='test3'/>
+ </channel>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/genericxml2xmloutdata/generic-chardev-tcp.xml
b/tests/genericxml2xmloutdata/generic-chardev-tcp.xml
new file mode 100644
index 0000000000..ef217c0abb
--- /dev/null
+++ b/tests/genericxml2xmloutdata/generic-chardev-tcp.xml
@@ -0,0 +1,35 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>1</vcpu>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-i686</emulator>
+ <controller type='virtio-serial' index='0'/>
+ <channel type='tcp'>
+ <source mode='connect' host='localhost'
service='5678'/>
+ <protocol type='raw'/>
+ <target type='virtio' name='test1'/>
+ </channel>
+ <channel type='tcp'>
+ <source mode='connect' host='localhost'
service='5678'/>
+ <protocol type='raw'/>
+ <target type='virtio' name='test2'/>
+ </channel>
+ <channel type='tcp'>
+ <source mode='bind' host='localhost'
service='5678'/>
+ <protocol type='raw'/>
+ <target type='virtio' name='test3'/>
+ </channel>
+ <memballoon model='none'/>
+ </devices>
+</domain>
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
index 5626eedf43..f5ad001968 100644
--- a/tests/genericxml2xmltest.c
+++ b/tests/genericxml2xmltest.c
@@ -105,6 +105,12 @@ mymain(void)
DO_TEST("cpu-cache-passthrough");
DO_TEST("cpu-cache-disable");
+ DO_TEST_DIFFERENT("chardev-tcp");
+ DO_TEST_FULL("chardev-tcp-missing-host", 0, false,
+ TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE);
+ DO_TEST_FULL("chardev-tcp-missing-service", 0, false,
+ TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE);
+
virObjectUnref(caps);
virObjectUnref(xmlopt);
--
2.13.5