On 05/26/2014 03:27 AM, Peter Krempa wrote:
On 05/23/14 18:38, Eric Blake wrote:
On 05/22/2014 07:47 AM, Peter Krempa wrote:
My future work will modify the metadata crawler function to use the storage driver file APIs to access the files instead of accessing them directly so that we will be able to request the metadata for remote files too. To avoid linking the storage driver to every helper file using the utils code, the backing chain traversal function needs to be moved to the storage driver source.
src/storage/storage_driver.c | 233 ++++++++++++++++++++++++++++++++++++++++++ src/storage/storage_driver.h | 5 + src/util/virstoragefile.c | 233 +-----------------------------------------
virStorageFileGetMetadataFromFDInternal(virStorageSourcePtr meta, int fd, int *backingFormat)
It's a bit confusing that we now have virStorageFile* functions spread across two different files; maybe a later patch should rename the storage_driver.h functions to have a different prefix?
We definitely can address this later. Any suggestions on the name of the moved code?
virStorageDriverFoo? It's slightly longer, so might cause long lines, but seems reasonable for the file name. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org