Re: [libvirt] [PATCHv1 02/13] Remove feature formating funcs from pool-specific options

On Fri, Apr 10, 2015 at 14:58:54 +0200, Ján Tomko wrote:

We only have one formatting function for the features. --- src/conf/storage_conf.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-)

ACK. I don't really see where we would have completely different feature sets for different pool types. Also if that would happen we can have a checker that rejects the unsupported ones for the given type and they can be in a single enum. Peter