Re: [libvirt] [PATCH v7 1/2] bhyve: add a basic driver
Daniel P. Berrange wrote:
> + virCommandAddArg(cmd, "-S");
> + virCommandAddArg(cmd, "31,uart");
Hmm, this is enabling a serial port right ? If so, you only want
todo this if you have def->nserials == 1 I reckon. What is the
string '31' saying ?
31 is pcislot here. Anyway, I've dropped these options for now.
I'd suggest this building is done before loading the domain
so you don't needlessly load the domain before we detect any
possible user configuration errors.
Good idea, appreciated it while testing incorrect disk type/bus checks.
Fixed in v8.
Thanks for the review!
Roman Bogorodskiy