Re: [libvirt] PATCH: Pass -uuid and -domid to QEMU if available

On Mon, Nov 03, 2008 at 12:52:40PM +0000, Daniel P. Berrange wrote: > Latest QEMU code now allows setting of the UUID in its SMBIOS data tables > via the -uuid command line arg. THis patch makes use of that feature by > pasing in the libvirt UUID for the VM. While doing this I also added > support for the Xenner specific -domid flag Seems some people were waiting for this :-) http://blog.loftninjas.org/?p=261 > @@ -901,10 +903,10 @@ static int qemudStartVMDaemon(virConnect > ret = virExec(conn, argv, progenv, &keepfd, &vm->pid, > vm->stdin_fd, &vm->stdout_fd, &vm->stderr_fd, > VIR_EXEC_NONBLOCK); > - if (ret == 0) { > - vm->def->id = driver->nextvmid++; > + if (ret == 0) > vm->state = migrateFrom ? VIR_DOMAIN_PAUSED : VIR_DOMAIN_RUNNING; > - } > + else > + vm->def->id = -1; Okay, i had a bit of trouble with that part of the patch, but I assume that since the id can come from the config file, it's already set at that point and we update to -1 only if the exec failed.