Re: [PATCH v2 0/6] ui: rework -show-cursor option
On Thu, 6 Feb 2020 at 11:29, Gerd Hoffmann <kraxel(a)redhat.com> wrote:
This cover letter is missing a description of what the patchset does...
The closest thing the patchset seems to get to documentation is the
oneliner in ui.json:
+# @show-cursor: Force showing the mouse cursor (default: off).
but looking at the ui/cocoa.m implementation that isn't what it
actually does -- it just seems to mean "default to shown on
startup", because the logic that unconditionally hides the host
cursor on mousegrab and unhides it on ungrab remains
unchanged. This doesn't on the face of it sound like very
useful behaviour, since the option will only have an effect for
the short period of time between QEMU startup and the first
mouse-grab, but without documentation of what the option
is intended to do and in particular how it's intended to
interact with grab/ungrab I don't know what your intention
for the behaviour was.
thanks
-- PMM