Re: [libvirt] [PATCH 1/4] rename qemuGetNumadAdvice to virDomainGetNumadAdvice
On Wed, Feb 27, 2013 at 05:11:06PM +0000, Daniel P. Berrange wrote:
On Wed, Feb 27, 2013 at 04:09:35PM +0800, Gao feng wrote:
> qemuGetNumadAdvice will be used by LXC driver,rename
> it to virDomainGetNumaAdvice and move it to domain_conf.c
>
> Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com>
> ---
> src/conf/domain_conf.c | 31 +++++++++++++++++++++++++++++++
> src/conf/domain_conf.h | 2 ++
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_process.c | 32 +-------------------------------
> 4 files changed, 35 insertions(+), 31 deletions(-)
Ewww no. The domain_conf.c file is for XML configuration
parsing & formatting. Code dealing with numad has no
business being there.
We don't currently have any place for general NUMA related
helper APIs, so I'd suggest you create a new pair of files
for these methods src/util/virnuma.h and src/util/virnuma.c
NB, you won't be able to pass in a virDomainDef when the code
is located here. Instead make the API accept 2 params, the vcpus
and memory values.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|