Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson
On Tue, May 15, 2018 at 10:23:52AM +0200, Andrea Bolognani wrote:
On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote:
> Per the discussion here:
> https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html
> Switch from using yajl to Jansson.
I expect Peter will review this, like he did for v1 and v2; however,
I wanted to point out that, while your series requires jansson 2.7,
Ubuntu 14.04 only ships jansson 2.5.
Given that the only 2.7 features my series currently uses are:
json_stringn (which allows parsing strings with NULL-bytes, not used
anyway) and the json_boolean_value alias for json_is_true,
downgrading the version to 2.5 is not a problem in this case.
While Ubuntu 14.04 is *not* a supported platform as per our recently
formalized support policy, it's also the only Linux platform
available on Travis CI, so dropping support for it would mean losing
the ability to perform Travis CI builds, at least with the QEMU
driver enabled.
But if this effectively adds another platform to our formalized support
policy, I will be unhappy when this prevents us from dropping some
outdated code.
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)