On Fri, Apr 13, 2012 at 02:13:59PM +0200, Guido Günther wrote:
Hi Laine, On Tue, Apr 03, 2012 at 08:27:39PM +0200, Guido Günther wrote:
On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote:
Hello,
On Tuesday 27 March 2012 18:30:17 Guido Günther wrote:
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote:
As scheduled, we are entering the freeze for 0.9.11. ... Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual !
Looks good so far on Debian's autobuilders:
https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental
Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52, gcc 4.4.5-8.) fails with CC libvirt_util_la-virnetdevbandwidth.lo util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a function)
The following patch fixes that for me: --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname ATTRIBUTE_UNUSED, return -1; } #endif /* !__linux__ */ -#if defined(__linux__) && defined(HAVE_LIBNL) +#if defined(__linux__) && defined(HAVE_LIBNL) && defined(IFLA_VF_MAX)
This looks reasonable to me since this isn't available in Debian Squeeze's kernel headers and I don't think it's worth a separate configure check since we'd only check for IFLA_VF_MAX there.
Can I go ahead and push this change?
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|