Re: [libvirt] [PATCH] storage: recognize gluster as networked file
On 11/05/2013 01:13 AM, Martin Kletzander wrote:
On Mon, Nov 04, 2013 at 02:30:50PM -0700, Eric Blake wrote:
> A qcow2 file with a backing file of 'gluster://host/vol/file' should
> not try to look for a directory named './gluster:/' in the file system.
>
> * src/util/virstoragefile.c (virBackingStoreIsFile): Broaden check
> to include all protocols.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
>
> + /* Reject anything that looks like a protocol (such as nbd:
or
> + * rbd:); if someone really does want a relative file name that
> + * includes ':', they can always prefix './'. */
This makes complete sense, I just can't figure out how qemu treats
this because when I tried it on upstream now, it ended up with a
segfault :)
A qemu segfault? Can you post the reproduction recipe?
> + if (colon && (!slash || colon < slash))
> return false;
> return true;
> }
Anyway, ACK.
Thanks; pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)