Martin Kletzander wrote:
On Thu, Oct 15, 2015 at 01:50:42PM +0200, Pino Toscano wrote:
>Use the virProcessGetStartTime implementation also when only the kernel
>is FreeBSD, such as on GNU/kFreeBSD.
>---
> src/util/virprocess.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/util/virprocess.c b/src/util/virprocess.c
>index e6b78ef..43118f8 100644
>--- a/src/util/virprocess.c
>+++ b/src/util/virprocess.c
>@@ -36,11 +36,11 @@
> # include <sched.h>
> #endif
>
>-#if defined(__FreeBSD__) || HAVE_BSD_CPU_AFFINITY
>+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || HAVE_BSD_CPU_AFFINITY
I'm guessing __FreeBSD_kernel__ is not defined when compiling on pure
FreeBSD, so we cannot use just __FreeBSD_kernel__, right?
That's true.
Weak ACK -- I have nowhere to try it and I'm lazy to install
such
machine just for trying out this patch, but I can clearly see it won't
break anything that works right now, so...
FWIW, it also looks fine to me (though I do not have GNU\kFreeBSD boxes
as well, only FreeBSD ones). I can build-test on FreeBSD just to be on a
safe side, but it doesn't seem like it could break something indeed.
Roman Bogorodskiy