On 3/28/19 8:51 AM, Eric Blake wrote:
So gcc isn't as smart as Coverity at seeing that it will always be initialized.
This fixes it:
diff --git a/src/conf/virdomainmomentobjlist.c b/src/conf/virdomainmomentobjlist.c index 92cf52dd..2e9343ff 100644 --- a/src/conf/virdomainmomentobjlist.c +++ b/src/conf/virdomainmomentobjlist.c @@ -165,7 +165,7 @@ virDomainMomentMoveChildren(virDomainMomentObjPtr from, virDomainMomentObjPtr to) { virDomainMomentObjPtr child; - virDomainMomentObjPtr last; + virDomainMomentObjPtr last = NULL;
Yep, will push shortly as a build-fixer. I'm assuming you're okay if I push it in your name, as you reported and posted the fix, even though it wasn't the usual git format.
Actually, I'm worried that this may trigger other warnings. I'll post a separate message with an alternative fix proposal, and we can choose which one looks nicer. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org