28 Aug
2014
28 Aug
'14
9:02 p.m.
On 08/28/2014 11:20 AM, Jim Fehlig wrote:
John Ferlan wrote:
I am going to remove this one from my series and let you handle it.
After looking at the code again, I think it is safest to go with your patch.
I would seem perhaps that the code was there to ensure that if either of the calls to virDomainObjSetState() ended up resulting in 'dom' not returning something from the virGetDomain(), then like perhaps the qemu migration code, the "best choice" was to remove it.
Yep, agreed. I haven't convinced myself that it is impossible for virGetDomain() to return a NULL domainPtr, but in the event it does I agree it is best to remove the domain.
Regards, Jim
Close enough to an ACK for me ;-) I've pushed the change Thanks John