On 04/25/2018 11:15 AM, Peter Krempa wrote:
The test cases would correspond to the following -drive command
lines:
file-backing_basic-detect.xml:
-drive
file=/var/lib/libvirt/images/a,format=qcow,if=none,id=drive-dummy,detect-zeroes=on
-device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
file-backing_basic-unmap-detect.xml:
-drive
file=/var/lib/libvirt/images/a,format=qcow,if=none,id=drive-dummy,discard=unmap,detect-zeroes=unmap
-device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
file-backing_basic-unmap-ignore.xml:
-drive
file=/var/lib/libvirt/images/a,format=qcow,if=none,id=drive-dummy,discard=ignore,detect-zeroes=on
-device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
file-backing_basic-unmap.xml:
-drive file=/var/lib/libvirt/images/a,format=qcow,if=none,id=drive-dummy,discard=unmap
-device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
---
tests/qemublocktest.c | 5 ++
.../xml2json/file-backing_basic-detect.json | 60 ++++++++++++++++++++
.../xml2json/file-backing_basic-detect.xml | 47 ++++++++++++++++
.../xml2json/file-backing_basic-unmap-detect.json | 64 ++++++++++++++++++++++
.../xml2json/file-backing_basic-unmap-detect.xml | 47 ++++++++++++++++
.../xml2json/file-backing_basic-unmap-discard.json | 0
^^ You have a stray
.../xml2json/file-backing_basic-unmap-ignore.json | 64
++++++++++++++++++++++
.../xml2json/file-backing_basic-unmap-ignore.xml | 47 ++++++++++++++++
.../xml2json/file-backing_basic-unmap.json | 63 +++++++++++++++++++++
.../xml2json/file-backing_basic-unmap.xml | 47 ++++++++++++++++
10 files changed, 444 insertions(+)
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-detect.json
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-detect.xml
create mode 100644
tests/qemublocktestdata/xml2json/file-backing_basic-unmap-detect.json
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap-detect.xml
create mode 100644
tests/qemublocktestdata/xml2json/file-backing_basic-unmap-discard.json
create mode 100644
tests/qemublocktestdata/xml2json/file-backing_basic-unmap-ignore.json
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap-ignore.xml
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap.json
create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-unmap.xml
Discarding the stray... (sorry)...
Yet another case where there's trust that you have the right output here...
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John