[...]
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 308d71f..2992197 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2134,6 +2134,9 @@ mymain(void) DO_TEST("tpm-passthrough", QEMU_CAPS_DEVICE_TPM_PASSTHROUGH, QEMU_CAPS_DEVICE_TPM_TIS); + DO_TEST("tpm-passthrough-crb", + QEMU_CAPS_DEVICE_TPM_PASSTHROUGH, QEMU_CAPS_DEVICE_TPM_TIS, IOW: This would have failed if you didn't add the TPM_TIS here... Yes. In that regard I was wondering how to go about these attributes. We don't want to start QEMU but only create its command line. Can we expect that someone running the tests has the latest QEMU on the system ? I can remove it when I copy /usr/local/bin/qemu-system... to /usr/bin/.
Check out the DO_TEST_CAPS_LATEST macro... Note the only consumer is 'disk-drive-write-cache' and it uses 'pc-i440fx-2.6' for a machine type - hopefully this helps with the other quandary.
I see that test case now that I rebased. Do I really need the DO_TEST_CAPS_LATEST? It works without it. Maybe due to some recent changes in libvirt it doesn't seem to require this capability in the local QEMU executable?
Stefan
Sorry busy day today... It should just be a simple rename of your .args file to have the x86_64.latest included and use of macro. If that doesn't work, then pkrempa will probably be interested. The macro is new - see commit 976fbb98 (and a few after that used it) John