On Fri, Sep 20, 2019 at 11:36:53AM +0200, Pavel Hrdina wrote:
On Fri, Sep 20, 2019 at 10:14:00AM +0100, Daniel P. Berrangé wrote:
On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote:
Meson build system is simple and quick compared to Autotools and it's able to fully replace our Autotools usage. There are few drawbacks as it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, it's still evolving and the user base is not that large and there were some tweaks required to achieve the same functionality.
However, there are benefits, the configure and build time is way shorter and build definition files are more readable and easier to maintain.
There are some major changes with Meson build system:
- there is no syntax-check target, the syntax-check is part of Meson test suite but it's still possible to run it separately,
- Meson forces separation between source and build directories
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> Tested-by: Ján Tomko <jtomko@redhat.com>
@@ -35,11 +36,11 @@ This package provides D-Bus API for libvirt %autosetup
%build -%configure -%make_build +%meson +%meson_build
%install -%make_install +%meson_install
%pre getent group %{system_user} >/dev/null || groupadd -r %{system_user}
Should this add a '%check' section to run '%meson_test' as sanity check for the build.
I would rather do it as a followup patch where we wound have to add more build dependencies into our spec file (python3, python3-pytest, python3-dbus and python3-flake8).
Sure, fine with me. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|