Re: [libvirt] [PATCH] graphics: add support for action_if_connected in qemu

> > + if (connected) { > + int action = virDomainGraphicsAuthConnectedTypeFromString(connected); > + if (action < 0) { > + virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED, > + _("unknown connected value %s"), Do we want to allow parsing "default"? If not, then change this to 'if (action <= 0)'.

> @@ -1755,7 +1760,7 @@ qemuDomainChangeGraphicsPasswords(struct qemud_driver *driver, > ret = qemuMonitorSetPassword(priv->mon, > type, > auth->passwd ? auth->passwd : defaultPasswd, > - NULL); > + auth->connected ? virDomainGraphicsAuthConnectedTypeToString(auth->connected) : NULL); Style - this results in a long line. It might be nicer to do: const char *connected = NULL; if (auth->connected) connected = virDomainGraphicsAuthConnectedTypeToString(auth->connected); ... qemuMonitorSetPassword(priv->mon, type, auth->passwd ? auth->passwd : defaultPasswd, connected); This is a new XML feature, but has missed the rc1 freeze, so v2 should not be applied until after the 0.9.2 release, although you can post it for review before then.