On 05/31/2011 03:09 PM, Eric Blake wrote:
+ if (connected) { + int action = virDomainGraphicsAuthConnectedTypeFromString(connected); + if (action < 0) { + virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unknown connected value %s"),
Do we want to allow parsing "default"? If not, then change this to 'if (action <= 0)'.
Still applicable to v2.
@@ -1755,7 +1760,7 @@ qemuDomainChangeGraphicsPasswords(struct qemud_driver *driver, ret = qemuMonitorSetPassword(priv->mon, type, auth->passwd ? auth->passwd : defaultPasswd, - NULL); + auth->connected ? virDomainGraphicsAuthConnectedTypeToString(auth->connected) : NULL);
Style - this results in a long line. It might be nicer to do:
const char *connected = NULL; if (auth->connected) connected = virDomainGraphicsAuthConnectedTypeToString(auth->connected); ... qemuMonitorSetPassword(priv->mon, type, auth->passwd ? auth->passwd : defaultPasswd, connected);
This is a new XML feature, but has missed the rc1 freeze, so v2 should not be applied until after the 0.9.2 release, although you can post it for review before then.
Serves me right for reading my inbox in order - I see you already posted v2: https://www.redhat.com/archives/libvir-list/2011-May/msg01871.html And now I'm wavering on whether this is a completely new feature, or enough of a bug-fix that we could get it into 0.9.2 anyways, since it is certainly minimal impact; so opinions from others would be helpful here. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org