[libvirt] [PATCH 12/12] qemu: command: Explain formatting of 'media=cdrom' in -drive

That is a frontend attribute but can't be moved. --- src/qemu/qemu_command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 08d96ef562..26ad3fe1af 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1761,6 +1761,9 @@ qemuBuildDriveStr(virDomainDiskDefPtr disk, qemuBuildDiskFrontendAttributes(disk, qemuCaps, bootindex, &opt); } + /* While this is a frontend attribute, it only makes sense to be used when + * legacy -drive is used. In modern qemu the 'ide-cd' or 'scsi-cd' are used. + * virtio and other just ignore the attribute anyways */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) { if (disk->bus == VIR_DOMAIN_DISK_BUS_SCSI) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SCSI_CD)) -- 2.14.3