Re: [libvirt] [PATCH 5/6] vbox: Don't leak arrays from XPCOM

XPCOM returns an array as a pointer to an array of pointers to the actual items. When the array isn't needed anymore the items are released, but the actual array containing the pointers to the items was not freed and leaked. Free the actual array using ComUnallocMem. This doesn't affect MSCOM as SafeArrayDestroy releases all items and frees the array. --- src/vbox/vbox_XPCOMCGlue.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index 5992350..dcaf682 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -339,6 +339,8 @@ vboxArrayRelease(vboxArray *array) } } + pVBoxFuncs_v2_2->pfnComUnallocMem(array->items); +