On Wed, Dec 18, 2013 at 06:25:07AM -0700, Eric Blake wrote:
On 12/18/2013 04:14 AM, Cédric Bosdonnat wrote:
D-bus introduced some changes in its locking code. Overriding the init function skips the new locking init and thus crashes later in libvirt test. Removing the function makes the test pass again. --- tests/virsystemdmock.c | 5 ----- 1 file changed, 5 deletions(-)
Ouch. We added the override because it was needed on older platforms. Have you tested that this doesn't break the test on RHEL 5?
Did we ? I saw this method was added right at the first commit of this code. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|