Re: [libvirt PATCH] rpm: always disable ceph on 32-bit
On Tue, Aug 25, 2020 at 12:11:30AM +0200, Jiri Denemark wrote:
On Fri, Aug 21, 2020 at 12:30:09 +0100, Daniel P. Berrangé wrote:
> The logic to disable Ceph on 32-bit was protected by a Fedora
> conditional. This is redundant as RHEL doesn't build on 32-bit
> platforms for years.
But libvirt is still built on i686 even on RHEL for 32b libraries. And
this includes libvirt-daemon-driver-storage-rbd sub-package. Actually
looking at the spec file, we even build libvirtd on i686 RHEL.
I should have clarified, that it isn't shipped on 32-bit for RHEL,
just built to get multi-lib libraries.
I think we would need a bigger change to make sure we only build
what's
really needed on i686, i.e., no libvirtd, no drivers usable only in
libvirtd, etc.
I don't think we need todo that unless something breaks, as that just
adds more complexity to the spec file. This change is simplifying by
removing conditionals for ceph.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|