Re: [libvirt] [PATCH v2 0/6] rewrite virt-host-validate to be data driven, using Go & YAML
Martin Kletzander <mkletzan(a)redhat.com> [2019-09-30, 10:47AM +0200]:
On Fri, Sep 27, 2019 at 01:52:19PM +0100, Daniel P. Berrangé wrote:
> 32 files changed, 2609 insertions(+), 1045 deletions(-)
So this ^^ plus:
2 languages added, 0 languages removed
makes me feel like this goes against what you were trying to do in another
series. I understand that adding new fact checks is "easier" and does not
require recompilation, but I don't see any use for that benefit. I went through
the cover letters for both series just to find a reason for it and I didn't.
Sorry, but I don't really like this.
I totally agree. Not only does this series fail to reduce the number of
languages of LOCs, it actually increases the complexity and
domain-specific knowledge to understand and contribute to libvirt.
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
IBM Systems
Linux on Z & Virtualization Development
--------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
--------------------------------------------------
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Attachments:
- signature.asc (application/pgp-signature — 902 bytes)