On 05/17/2010 02:52 PM, Jim Meyering wrote:
It's a good thing the latter while loop condition could never be true -- otherwise it'd be an infloop.
static int qemuTeardownDiskCgroup(virCgroupPtr cgroup, virDomainObjPtr vm, virDomainDiskDefPtr disk) { char *path = disk->src; int ret = -1;
- while (path != NULL) { + do { virStorageFileMetadata meta; int rc;
VIR_DEBUG("Process path %s for disk", path); ... path = meta.backingStore; } while (path != NULL);
Are we sure disk->src is guaranteed to be non-NULL on entry, or would have been better to rewrite this as while{}/*nothing*/ instead of do{}while? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org