On Thu, May 09, 2013 at 12:12:33PM -0600, Eric Blake wrote:
On 05/09/2013 07:12 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The previous update of method naming missed the ESX storage backend files. Update them is that the driver impl methods follow the naming of the public API but with s/vir/esx/
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/esx/esx_storage_backend_iscsi.c | 104 ++++++++++++++++++------------------ src/esx/esx_storage_backend_vmfs.c | 104 ++++++++++++++++++------------------ 2 files changed, 104 insertions(+), 104 deletions(-)
ACK. Mostly mechanical, and consistent with other patches.
Didn't you write a 'make check' rule that was supposed to catch mismatches? If so, doesn't that rule need to be updated to avoid regressions in this file, since obviously this file escaped detection the first time?
Yes, but I missed these 2 files from the list of those checked. This is now fixed by https://www.redhat.com/archives/libvir-list/2013-May/msg00696.html Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|