Re: [libvirt] [PATCH v2 11/12] virsh: add helper for returning event name string
On 05/15/2018 11:32 AM, Lin Ma wrote:
>> (btw, there are other 'vshEventCallbacks' array which
defining in
>> virsh-secret.c,
>> virsh-pool.c and virsh-nodedev.c.we only move the vshEventCallbacks and
>> related
>> data structures from virsh-domain.c?)
> We can have virshSecretEventToString(), virshPoolEventToString(), ...
> exposed and used in completers.
The function names about *EventToString are already occupied,
Oh, we can't just export them. Not because of they already exist but
because they don't really do what we expect them to do. At least
virshSecretEventToString() doesn't. Anyway, I'm including a patch that
does what I'm trying to say.
Also, virshSecretEventToString() should be renamed to
virshSecretLifecycleEventToString().
Michal
Attachments:
- secret-event.patch (text/x-patch — 4.3 KB)