Re: [libvirt PATCH 000/351] port libvirt to Meson build system
On Fri, Jul 17, 2020 at 16:04:16 +0200, Peter Krempa wrote:
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
I've tried building RPMs both from the pre-patch tree state and after
your patchset. I've then extracted all the RPMs toghether and compared
the file lists (minus the 'build-id' directory which differs).
I'm not sure whether it's due to the RPM or regular build process
though.
I've also started to verify file differences:
config files which are installed in /etc/libvirt from said RPMs were not
post-processed.
E.g. virtnetworkd.conf:
The meson-originated version has:
# Set the name of the directory in which sockets will be found/created.
#
# This setting is not required or honoured if using systemd socket
# activation with systemd version >= 227
#
#unix_sock_dir = "@runstatedir@/libvirt"
while automake:
# Set the name of the directory in which sockets will be found/created.
#
# This setting is not required or honoured if using systemd socket
# activation with systemd version >= 227
#
#unix_sock_dir = "/run/libvirt"
A non-exhaustive list of differences that I can see:
automakerpm/unpack/etc/libvirt/virtinterfaced.conf
automakerpm/unpack/etc/libvirt/virtlxcd.conf
automakerpm/unpack/etc/libvirt/virtnetworkd.conf
automakerpm/unpack/etc/libvirt/virtnodedevd.conf
automakerpm/unpack/etc/libvirt/virtnwfilterd.conf
automakerpm/unpack/etc/libvirt/virtqemud.conf
automakerpm/unpack/etc/libvirt/virtsecretd.conf
automakerpm/unpack/etc/libvirt/virtstoraged.conf
automakerpm/unpack/etc/libvirt/virtvboxd.conf
automakerpm/unpack/etc/libvirt/virtxend.conf