On 01/02/2013 11:39 AM, Daniel P. Berrange wrote:
On Wed, Jan 02, 2013 at 11:26:18AM -0700, Eric Blake wrote:
A recent build failure made me realize that we could usefully add a bit more information to configure output, for aid in analysis of failed builds. Pulling in the autobuild module merely adds these four lines to configure output:
configure: autobuild project... libvirt configure: autobuild revision... 1.0.1
I'd suggest the GIT head hash be added too.
Hmm, that would indeed be useful. It looks like it is as simple as modifying the shell variable AB_VERSION to contain more details, prior to invoking any gnulib macros; I'll play with a configure.ac patch appropriately, and post a v2 if I get it working.
I'll wait for a review on this one. Hmm, I also realized that there are other things that might be useful for autobuild to log, such as uname output; I'll ask upstream if it is worth enhancing the autobuild output, and if upstream agrees, then we would pick up that enhanced information next time we sync from gnulib.
Asked: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/32280
bootstrap.conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
ACK
If I get to the end of the day without a v2, then I'll push this. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org