Re: [libvirt] [PATCH 4/6] storage: fs: Process backing store data in virStorageBackendProbeTarget

15 Jul 2014

      On 07/15/2014 07:25 AM, Peter Krempa wrote:
...
Move the processing of the backend metadata directly to the helper
instead of passing it through arguments to the function.
---
 src/storage/storage_backend_fs.c | 72 ++++++++++++++++++----------------------
 1 file changed, 33 insertions(+), 39 deletions(-)

...
+
+        if (target->backingStore->format == VIR_STORAGE_FILE_AUTO) {
+            if (!virStorageIsFile(target->backingStore->path) ||
+                (rc = virStorageFileProbeFormat(target->backingStore->path,
+                                                    -1, -1)) < 0) {
Indentation is off.

ACK with that nit fixed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org