On Mon, 2019-06-03 at 14:13 +0200, Ján Tomko wrote:
On Fri, May 31, 2019 at 05:22:01PM +0200, Andrea Bolognani wrote:
+int +virNumaNodesetToCPUset(virBitmapPtr nodeset, + virBitmapPtr *cpuset)
I'd prefer the output argument to be first - see VIR_STRDUP. But I have no stats about which style is prevailing.
The name of the function is virNumaNodesetToCPUset(), so having the cpuset argument first and the nodeset argument second would be very confusing :)
+int +virNumaNodesetToCPUset(virBitmapPtr nodeset, + virBitmapPtr *cpuset) +{
util/virnuma.c:399:37: error: unused parameter 'nodeset' [-Werror,-Wunused-parameter] virNumaNodesetToCPUset(virBitmapPtr nodeset, ^ 1 error generated.
Good catch, compiler! Fixed it locally. -- Andrea Bolognani / Red Hat / Virtualization