Re: [libvirt] [PATCH]: Export the 'label' on block devices
Chris Lalancette <clalance(a)redhat.com> wrote:
Daniel P. Berrange wrote:
>> diff -u -r1.15 storage_backend_fs.c
>> --- a/src/storage_backend_fs.c 13 Oct 2008 16:46:29 -0000 1.15
>> +++ b/src/storage_backend_fs.c 16 Oct 2008 12:31:23 -0000
>> @@ -48,7 +48,8 @@
>> #include "xml.h"
>>
>> enum {
>> - VIR_STORAGE_POOL_FS_AUTO = 0,
>> + VIR_STORAGE_POOL_FS_UNKNOWN = 0,
>> + VIR_STORAGE_POOL_FS_AUTO = 1,
>
> This shouldn't be added - automatic is intended to be default.
>
>>
>> enum {
>> - VIR_STORAGE_VOL_RAW,
>> + VIR_STORAGE_VOL_UNKNOWN = 0,
>> + VIR_STORAGE_VOL_RAW = 1,
>
OK, hopefully last try. Fixed the above two errors and made the disk_type array
static as suggested by Jim.
ACK.
Looks fine, applied, and passed smoke test:
make check && make syntax-check