Re: [libvirt] [PATCH] Query block allocation extent from QEMU monitor

On 05/14/2010 07:10 AM, Daniel P. Berrange wrote: > The virDomainGetBlockInfo API allows query physical block > extent and allocated block extent. These are normally the > same value unless storing a special format like qcow2 > inside a block device. In this scenario we can query QEMU > to get the actual allocated extent. > > Since last time: > > - Return fatal error in text monitor > - Only invoke monitor command for block devices > - Fix error handling JSON code > > * src/qemu/qemu_driver.c: Fill in block aloction extent when VM > is running > * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h, > src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_json.h, > src/qemu/qemu_monitor_text.c, src/qemu/qemu_monitor_text.h: Add > API to query the highest block extent via info blockstats On 05/18/2010 02:32 PM, Eric Blake wrote: > On 05/16/2010 03:03 AM, Daniel P. Berrange wrote: >>> that means you now propagate that fatal error out of the call, rather >>> than falling back on the default. >> >> Yes, that is the intended behaviour here. If it is a block device + not using >> the raw format, then we want the caller to be able to see the error > > Fair enough. By the way, I never saw this one applied, even though DV > gave it an ACK... I applied this on Daniel's behalf, as part of cleaning out some of my inbox, and after double-checking that everything builds cleanly after rebasing on latest sources.