On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
Kept the subject the same, but the concept has been adjusted to follow issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML. This series adds both the NFS and the RBD adjustments that were essentially in the referenced series from review.
Can you give any info about what motivated this addition.
There's a bz: https://bugzilla.redhat.com/show_bug.cgi?id=1584663 which along the way has had private comments - I probably should add the bz to at least one of the patches, but I think because of the (probably unnecessary) private comments in the bz, I was hesitant to do so. I tried a different mechanism and Jano pointed out: https://www.redhat.com/archives/libvir-list/2018-December/msg00667.html that previous attempts were rejected due to the arbitrary text.
Anything that is implemented via a separate XML namespace is generally considered
"unsupported, you're on your own when it breaks"
so if this feature is neeeded for any management application like oVirt, OpenStack, etc, then using a custom namespace is not going to be a suitable approach.
And I don't think it would be palatable to add N 'text' options to the XML that map to the same N 'text' options in the mount command. So this was the next best option as far as I saw it. That'd be one of those never ending tasks to add the favorite option. John