Re: [libvirt] [PATCH v2 3/3] docs: news: Provide an update about the video type 'none'

On Fri, Jul 13, 2018 at 02:02:10PM +0200, Ján Tomko wrote: > On Thu, Jul 12, 2018 at 05:08:48PM +0200, Erik Skultety wrote: > > Signed-off-by: Erik Skultety <eskultet(a)redhat.com&gt; > > --- > > docs/news.xml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/docs/news.xml b/docs/news.xml > > index 773c95b0da..93832acc4c 100644 > > --- a/docs/news.xml > > +++ b/docs/news.xml > > @@ -46,6 +46,20 @@ > > </change> > > </section> > > <section title="Improvements"> > > + <change> > > + <summary> > > + qemu: Introduce a new video model of type 'none' > > + </summary> > > + <description> > > + Historically, libvirt would add a default 'cirrus' video device to > > + a guest if the XML specified 'graphics' but lacked 'video'. > > Historical behavior is hardly news :P > > > This can > > + be incovenient with GPU mediated devices which can serve as the only > > + rendering devices within the guest, rather than still relying on an > > + emulated GPU which would also be the primary device. Having a 'none' > > + model is our only backwards compatible option how to turn this legacy > > + behaviour off when needed. > > How about: > > Introduce a new video model type that disables the automatic addition of > a video device to domains with 'graphics' specified in their XML. > > This can be useful with GPU mediated devices which can serve as the only > rendering devices within the guest. Much better, thanks. I didn't get an explicit ACK or a RB, so may I presume one?